Skip to content

Drop system headers from cling command line - #23700

Merged
pcanal merged 1 commit into
root-project:masterfrom
ktf:fix-xcode-27-mix
Oct 14, 2026
Merged

pcanal merged 1 commit into
root-project:masterfrom
ktf:fix-xcode-27-mix

Conversation

@ktf

@ktf ktf commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Avoid mixing XCode 27 includes with the cling ones.

Avoid mixing XCode 27 includes with the cling ones.
@ktf
ktf requested review from dpiparo and pcanal as code owners October 13, 2026 13:16
@ktf

ktf commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Ongoing tests in alisw/alidist#6332

Comment thread core/dictgen/src/rootcling_impl.cxx

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ktf

ktf commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

For the record: https://www.youtube.com/watch?v=rUVEFkjqiEE

@pcanal

pcanal commented Oct 13, 2026

Copy link
Copy Markdown
Member

Ongoing tests in alisw/alidist#6332

The result logs are not public. The builds seems to have failed but I am not sure if it is related.

@github-actions

Copy link
Copy Markdown

Test Results

    24 files      24 suites   4d 4h 16m 31s ⏱️
 3 886 tests  3 885 ✅ 0 💤 1 ❌
83 180 runs  83 179 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 1c44e50.

@ktf

ktf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

The tests are now failing, but for something unrelated. IMHO this can be merged.

@pcanal

pcanal commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thanks.

@ktf

ktf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

For the record, the unrelated crashes seems to be fixed by #23719.

@pcanal
pcanal merged commit b304aa5 into root-project:master Oct 14, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants