Repository navigation
Conversation
Test Results 24 files 24 suites 4d 1h 37m 40s ⏱️ Results for commit 261bb59. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-soa-prod
branch
from
October 13, 2026 09:32
1314cde to
261bb59
Compare
pcanal
reviewed
Oct 16, 2026
| ROOT::RSoAField::RSoAField(std::string_view fieldName, TClass *clSoA) | ||
| : ROOT::RRuleField(fieldName, GetRenormalizedTypeName(clSoA->GetName()), clSoA, ROOT::ENTupleStructure::kCollection) | ||
| { | ||
| static std::once_flag once; |
Member
There was a problem hiding this comment.
Do we have confirmation from CMS that they were successful in trying out on at least one non-trivial use case?
Contributor
Author
There was a problem hiding this comment.
It has been presented to CMS. The "element-wise columnar arrays" are still missing for a complete example. This will be added soon but doesn't invalidate any of the existing structure. Easier use cases can already benefit from this feature.
pcanal
approved these changes
Oct 16, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
Assuming this means we have covered (most of) the CMS use cases.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19230