Repository navigation
[roottest] Use std::filesystem in checkRuntimeIncludePaths.C - #23676
Open
guitargeek wants to merge 1 commit into
Open
guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Replace the hand-written path normalization in the interpreted test macro with std::filesystem::path::lexically_normal() and std::filesystem::weakly_canonical(). The helpers were written by hand in PR root-project#23649 because an earlier revision of that PR, which used <filesystem> and <regex>, failed on the Windows CI with: [runStaticInitializersOnce]: Failed to materialize symbols: { ... } This change reintroduces only <filesystem>, keeping the hand-written flag parser instead of <regex>, to show that failure in isolation. See root-project#23664.
Test Results 22 files 22 suites 3d 11h 11m 30s ⏱️ For more details on these failures, see this check. Results for commit d4bf976. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Oct 10, 2026
dpiparo
left a comment
dpiparo
left a comment
Member
There was a problem hiding this comment.
provided the failures are understood
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-written path normalization in the interpreted test macro with std::filesystem::path::lexically_normal() and std::filesystem::weakly_canonical(). The helpers were written by hand in PR #23649 because an earlier revision of that PR, which used and , failed on the Windows CI with:
This change reintroduces only
<filesystem>, keeping the hand-written flag parser instead of<regex>, to show that failure in isolation. See #23664.