Repository navigation
[Arlesienne] Update test for v1 streamer field to realistic handle alignm… - #23661
Merged
pcanal merged 1 commit intoOct 16, 2026
Merged
Conversation
…ent. Move the (so far ununused) VersionedStreamerField in the right header and dictionary. Attach that type as the data type of the test RVersionStreamerField which has been updated to record the class and use its alignment and sizeof.
jblomer
approved these changes
Oct 8, 2026
Test Results 22 files 22 suites 3d 17h 14m 50s ⏱️ Results for commit 23647ee. ♻️ This comment has been updated with latest results. |
Member
Author
|
The two failures seems unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the (so far ununused) VersionedStreamerField in the right header and dictionary.
Attach that type as the data type of the test RVersionStreamerField which has been updated
to record the class and use its alignment and sizeof.
Without this fix, the test asserting inside RNTuple due to the zero value alignment.