Repository navigation
[core] Add comprehensive unit tests for TString - #23607
Closed
ravindra-RKB wants to merge 1 commit into
Closed
ravindra-RKB wants to merge 1 commit into
ravindra-RKB wants to merge 1 commit into
Conversation
ravindra-RKB
requested review from
dpiparo,
jblomer,
pcanal and
silverweed
as code owners
October 4, 2026 17:56
ravindra-RKB
force-pushed
the
feature-tstring-tests
branch
from
October 4, 2026 17:57
0e7be8b to
8483894
Compare
ravindra-RKB
force-pushed
the
feature-tstring-tests
branch
from
October 6, 2026 18:01
8483894 to
9f0fb36
Compare
This PR adds several standard tests for the foundational TString class to improve core test coverage. Methods covered include Contains, ReplaceAll, ToUpper, ToLower, Form, operator(), and Tokenize.
ravindra-RKB
force-pushed
the
feature-tstring-tests
branch
from
October 7, 2026 09:05
9f0fb36 to
fcaab5d
Compare
Contributor
|
Closing with the same rationale as in #23824 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for the foundational
TStringclass in thecoremodule by adding missing comprehensive unit tests toTStringTest.cxx.Added test cases for:
ContainsReplaceAllToUpper/ToLowerFormSubstringTokenizeNo changes were made to the core logic, only GTest test files.