Repository navigation
[ci] Build exactly the pushed commit in push-triggered workflows - #23601
Merged
guitargeek merged 1 commit intoOct 4, 2026
Merged
Conversation
Push-triggered jobs passed only --base_ref <branch> to build_root.py, so they built whatever the branch pointed to when the job (re)started, which can be a later commit. That made post-merge builds unreliable as indicators of which commit broke a configuration. build_root.py now accepts --sha for non-PR builds as well and, after the branch clone/pull, resets the checkout to exactly the commit that triggered the workflow (github.sha). If the commit is missing locally (e.g. the branch was force-pushed meanwhile), it is fetched explicitly from the repository. The macOS step combines schedule and push: the sha is passed only for push events, so nightlies keep tracking the branch tip. Fixes root-project#14061 🤖 Done with the help of AI
dpiparo
approved these changes
Oct 3, 2026
Test Results 24 files 24 suites 3d 22h 32m 1s ⏱️ For more details on these failures, see this check. Results for commit 377beee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push-triggered jobs passed only --base_ref to build_root.py, so they built whatever the branch pointed to when the job (re)started, which can be a later commit. That made post-merge builds unreliable as indicators of which commit broke a configuration.
build_root.py now accepts --sha for non-PR builds as well and, after the branch clone/pull, resets the checkout to exactly the commit that triggered the workflow (github.sha). If the commit is missing locally (e.g. the branch was force-pushed meanwhile), it is fetched explicitly from the repository.
The macOS step combines schedule and push: the sha is passed only for push events, so nightlies keep tracking the branch tip.
Fixes #14061
🤖 Done with the help of AI