Repository navigation
[cppyy] Remove xfail for addressof method test on modules=OFF with C++17 - #23581
Merged
guitargeek merged 1 commit intoOct 2, 2026
Merged
Conversation
Since the nightly of 2026-09-29, TestDATATYPES.test49_addressof_method passes again on the alma9 modules_off build, after failing consistently since the xfail was added in January. The transition window (04c4c5c..b6a95ff, including the LLVM tag bump) contains no commit that fixes the kind of AST-level specialization confusion seen in issue root-project#21005, so the recovery is most likely an incidental PCH-content layout shift rather than a root-cause fix. Meanwhile, the strict xfail now fails the nightly suite with XPASS(strict), so it has to go either way. The unrelated macOS-ARM xfail condition is kept, and the now-unused is_modules_off helper and has_cpp_20 import are removed. Closes root-project#21005.
aaronj0
approved these changes
Oct 2, 2026
dpiparo
approved these changes
Oct 2, 2026
dpiparo
left a comment
dpiparo
left a comment
Member
There was a problem hiding this comment.
Thanks for this investigation.
I think this is an easy one, given that, by construction, we already have the test to catch any potential future regression
Test Results 24 files 24 suites 4d 1h 48m 16s ⏱️ Results for commit e93d4cb. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the nightly of 2026-09-29, TestDATATYPES.test49_addressof_method passes again on the alma9 modules_off build, after failing consistently since the xfail was added in January. The transition window (04c4c5c..b6a95ff, including the LLVM tag bump) contains no commit that fixes the kind of AST-level specialization confusion seen in issue #21005, so the recovery is most likely an incidental PCH-content layout shift rather than a root-cause fix. Meanwhile, the strict xfail now fails the nightly suite with XPASS(strict), so it has to go either way.
The unrelated macOS-ARM xfail condition is kept, and the now-unused is_modules_off helper and has_cpp_20 import are removed.
Closes #21005.