Repository navigation
[sql] Add unit tests for TSQLiteServer and SQLite interfaces - #23519
Conversation
|
Hi, thanks for the proposal. Could you keep the test environment clean, for example by wrapping the creation of the db in a RAII object for example? This will not leave sqlite files around. |
|
Hi @dpiparo, thanks for the feedback! Yep, I had a look at the contributing guide and I'm fully aware of the rules. I take full responsibility for the code I'm submitting and I'll make sure it's up to the project's standards. Good catch on the RAII part! I just pushed an update that wraps the database creation using Let me know if it looks good to you now or if I should change anything else! |
Test Results 24 files 24 suites 4d 3h 28m 50s ⏱️ For more details on these failures, see this check. Results for commit 67b1dfc. ♻️ This comment has been updated with latest results. |
a510739 to
fc3389d
Compare
Adds Google Test unit tests for the TSQLiteServer, TSQLiteResult, TSQLiteStatement, and TSQLiteRow classes to improve test coverage in the sql module.
fc3389d to
67b1dfc
Compare
|
Thanks @linev for the review and approval! Rebased onto latest master to re-run the CI checks. |
This Pull request:
Changes or fixes:
This PR adds comprehensive unit testing to the
sql/sqlitemodule, which was previously lacking test coverage. It implements a suite ofgtestcases insidesql/sqlite/test/test_sqlite.cxxto testTSQLiteServer,TSQLiteResult,TSQLiteRow, andTSQLiteStatement.The added tests include:
Exec().Query()andTSQLResult/TSQLRow.GetTableInfo().TSQLStatement.Checklist: