Repository navigation
[df] Add initial RNTupleProcessor data source - #23477
Merged
Merged
Conversation
enirolf
requested review from
bellenot,
hageboeck,
jblomer,
silverweed and
vepadulano
as code owners
September 24, 2026 07:54
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
2 times, most recently
from
September 24, 2026 08:30
3316612 to
c3a5911
Compare
silverweed
reviewed
Sep 24, 2026
silverweed
left a comment
silverweed
left a comment
Contributor
There was a problem hiding this comment.
Just a few minor comments
Test Results 24 files 24 suites 4d 1h 19m 27s ⏱️ For more details on these failures, see this check. Results for commit 4c09dc9. ♻️ This comment has been updated with latest results. |
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
2 times, most recently
from
September 28, 2026 09:46
f65c7e0 to
f69246e
Compare
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
from
October 7, 2026 14:20
f69246e to
46963eb
Compare
jblomer
approved these changes
Oct 7, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Very nice! In principle LGTM.
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
from
October 8, 2026 14:31
46963eb to
291963d
Compare
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
from
October 9, 2026 09:14
291963d to
fa27a98
Compare
vepadulano
approved these changes
Oct 12, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thank you! I left a couple of minor comments for consideration.
In preparation for the addition of RNTupleProcessorDS.
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
from
October 13, 2026 08:56
fa27a98 to
0d63702
Compare
In the experimental namespace. For now, it is single-threaded only. In principle, the full type system (as tested for the regular RNTuple DS) works, with the exception of arrays that are part of classes. This will be addressed in a future commit.
enirolf
force-pushed
the
ntuple-ds-processor-pt1
branch
from
October 13, 2026 14:17
0d63702 to
4c09dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial (single-thread only) implementation for an RDataSource based on the RNTupleProcessor.
The implementation is adopted from
RNTupleDS, and adapted for theRNTupleProcessorwhere needed.Dataframes based on this data soruce can be created with the
ROOT::Experimental::RDF::FromRNTupleProcessorfactory, which takes an already-exisiting processor as its argument.Almost all tests (all taken from
datasource_ntuple) pass, except for the more involved array-based ones. These are commented out for now and will be addressed in the future.