Skip to content

[ci] fix typo in replicate build message #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 2 commits into from
Sep 19, 2026
Merged

[ci] fix typo in replicate build message #23399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14169c1
[ci] fix typo in replicate build message
ferdymercury Sep 17, 2026
f3950a4
[nfc] fix comment
ferdymercury Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/build_root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def main():

args = parse_args()

build_utils.log = build_utils.Tracer(args.platform_config, args.dockeropts)
build_utils.log = build_utils.Tracer(args.platform, args.platform_config, args.dockeropts)

pull_request = args.head_ref and args.head_ref != args.base_ref

Expand Down
18 changes: 12 additions & 6 deletions .github/workflows/root-ci-config/build_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,14 @@ class Tracer:
Trace command invocations and print them to reproduce builds.
"""

image = ""
platform = ""
platform_config = ""
docker_opts = []
trace = ""

def __init__(self, image: str, docker_opts: str):
self.image = image
def __init__(self, platform: str, platform_config: str, docker_opts: str):
self.platform = platform
self.platform_config = platform_config
if docker_opts:
self.docker_opts = docker_opts.split(' ')
if '--rm' in self.docker_opts:
Expand All @@ -73,16 +75,20 @@ def add(self, command: str) -> None:
@github_log_group("To replicate this build locally")
def print(self) -> None:
if self.trace != "":
if self.image and not is_macos():
if self.platform and not is_macos():
print(f"""\
# Grab the image and set up the python virtual environment:
docker run {' '.join(self.docker_opts)} -it registry.cern.ch/root-ci/{self.image}:buildready
docker run {' '.join(self.docker_opts)} -it registry.cern.ch/root-ci/{self.platform}:buildready
if [ -d /py-venv/ROOT-CI/bin/ ]; then . /py-venv/ROOT-CI/bin/activate && echo PATH=$PATH >> $GITHUB_ENV; fi
""")
if self.platform != self.platform_config:
print(f"""\
# Note that the variant {self.platform_config} will be used when configuring
""")
print(self.trace)


log = Tracer("", "")
log = Tracer("", "", "")


def print_fancy(*values, sgr=1, **kwargs) -> None:
Expand Down
Loading