Repository navigation
[CI] add --dry_run to build_root.py - #23283
Merged
Merged
Conversation
dpiparo
approved these changes
Sep 7, 2026
Test Results 21 files 21 suites 3d 14h 12m 54s ⏱️ For more details on these failures, see this check. Results for commit 321b38b. ♻️ This comment has been updated with latest results. |
hageboeck
reviewed
Sep 22, 2026
hageboeck
left a comment
hageboeck
left a comment
Member
There was a problem hiding this comment.
While what you did is clean, I think a hack setting a global or an attribute could be good enough in this case.
silverweed
force-pushed
the
build_root_dry_run
branch
from
September 29, 2026 15:35
93d9331 to
321b38b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--dry_runflag which tries its best to causebuild_root.pyto run to completion without actually doing anything. Useful for quick local debugging.