Repository navigation
[xvertext] mv to builtins directory - #23172
Merged
Merged
Conversation
ferdymercury
added
clean build
Test Results 23 files 23 suites 3d 14h 21m 7s ⏱️ Results for commit 6943e9c. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
bxvertext
branch
from
August 28, 2026 06:24
4d259b1 to
6943e9c
Compare
ferdymercury
marked this pull request as ready for review
August 28, 2026 06:50
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
August 28, 2026 06:50
Member
|
@linev, sorry for the trivial question, but do we need this external or can we replace it with something else, e.g. xft? |
Member
|
It is ancient code to draw plain text with X11 and implement simple rotation of such text. Actually this is the reason why we have |
linev
approved these changes
Aug 28, 2026
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Oct 16, 2026
* [cmake] mv xvertext to builtins * [cmake] restore xvertext as C library independent from ROOT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better separation internal/externals and license auditing
Was only having minor modifications wrt original