Repository navigation
[cmake] mv win32gdk to builtins - #23171
Merged
Merged
Conversation
ferdymercury
added
clean build
Test Results 23 files 23 suites 3d 22h 40m 5s ⏱️ For more details on these failures, see this check. Results for commit 20c7863. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Aug 27, 2026
ferdymercury
commented
Aug 29, 2026
This comment was marked as outdated.
This comment was marked as outdated.
to avoid clash with std::byte
avoid undefined GetObject
for getcurrentthreadid
ferdymercury
marked this pull request as ready for review
August 31, 2026 15:36
ferdymercury
commented
Sep 1, 2026
Collaborator
Author
|
CI failures seem unrelated |
Member
|
Let's wait for @bellenot to have a look. |
bellenot
reviewed
Sep 29, 2026
ferdymercury
commented
Sep 29, 2026
bellenot
reviewed
Sep 30, 2026
bellenot
reviewed
Sep 30, 2026
bellenot
reviewed
Sep 30, 2026
bellenot
left a comment
bellenot
left a comment
Member
There was a problem hiding this comment.
LGTM, but I'll test locally, just to be sure...
ferdymercury
commented
Sep 30, 2026
ferdymercury
commented
Sep 30, 2026
thks to bellenot
Collaborator
Author
|
Thanks for the review! Shall I squash and force-push? Or can you click, once ready, on "squash-on-merge" ? |
Member
You're very welcome! And I'll squash-on-merge |
bellenot
self-requested a review
October 1, 2026 08:40
bellenot
approved these changes
Oct 1, 2026
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Oct 16, 2026
* [cmake] mv win32gdk to builtins * [cmake] fix paths * [cmake] fix path * [win32] fix include path * [win32] make GDKlib a private dependency * [win32] fwd declare rather than include header to avoid clash with std::byte * [cmake] try fix iconv * Pathfixes * Update CMakeLists.txt * fix paths * add missing include files * fix fw declaration * fix duplicated definitions * swap include paths * missing header * Update TGWin32.cxx avoid undefined GetObject * Update TGWin32VirtualGLProxy.cxx for getcurrentthreadid * Update TGWin32VirtualXProxy.cxx * Apply batched suggestions from code review Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com> * Update TGWin32.cxx * Update Windows4Root.h * [cmake] avoid polluting source directory * rm global include dirs * Update CMakeLists.txt * Apply suggestion from @ferdymercury * fix include path * missing incpath * dupe header * rm redundant headers thks to bellenot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better separate externals from internals
In a future PR one could improve this by creating a native CMake build system rather than custom commands.