Skip to content

[clang] Upstream patch for AST generation - #23166

Draft
hahnjo wants to merge 2 commits into
root-project:masterfrom
hahnjo:refactor-generation
Draft

hahnjo wants to merge 2 commits into
root-project:masterfrom
hahnjo:refactor-generation

Conversation

@hahnjo

@hahnjo hahnjo commented Aug 27, 2026

Copy link
Copy Markdown
Member

Test llvm/llvm-project#219189 in our CI, across all platforms.

@hahnjo hahnjo self-assigned this Aug 27, 2026
@hahnjo hahnjo added in:Cling clean build Ask CI to do non-incremental build on PR labels Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 16h 57m 29s ⏱️
 3 872 tests  3 870 ✅ 0 💤 2 ❌
80 027 runs  80 025 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 9f63c51.

♻️ This comment has been updated with latest results.

@vgvassilev

Copy link
Copy Markdown
Member

IIRC, that came from CMSSW scale deployments.

@hahnjo

hahnjo commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

IIRC, that came from CMSSW scale deployments.

If you have pointers what to look at, I will take it. For the moment, this looks like a bug in the code if you register multiple ExternalASTSources, which we do in Cling. Without either of the fixes, it actually errors out during build because some Redelcarables are not found from deserialization.

ExternalASTSource::incrementGeneration returns the OldGeneration,
which must be taken into account in case it is delegated to the
topmost external source.

This obsoletes a long-standing downstream patch in Cling that was
previously submitted in https://reviews.llvm.org/D39714.
@hahnjo
hahnjo force-pushed the refactor-generation branch from 714b771 to 9f63c51 Compare September 25, 2026 11:23
@hahnjo

hahnjo commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

ping @vgvassilev, llvm/llvm-project#219189 landed upstream a while ago

@hahnjo hahnjo changed the title [clang] Test upstream patch for AST generation [clang] Upstream patch for AST generation Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:Cling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants