Repository navigation
[graf3d] mv glu to builtins and make it a build option OFF by default - #23161
Merged
Merged
Conversation
ferdymercury
added
clean build
Test Results 23 files 23 suites 3d 14h 30m 5s ⏱️ For more details on these failures, see this check. Results for commit 70ee78a. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
August 26, 2026 22:57
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
August 26, 2026 22:57
linev
reviewed
Aug 27, 2026
ferdymercury
commented
Aug 27, 2026
Member
|
Thanks for this work. |
ferdymercury
commented
Aug 27, 2026
Collaborator
Author
|
@bellenot for Windows there is |
ferdymercury
commented
Aug 28, 2026
OpenGL::GLU CMake target exists but header is in a different path
and rm glew remnant since now glad is used
as suggested by linev Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Member
I'll have to check and try with both options... |
Collaborator
Author
It seems it works in the CI now |
Collaborator
Author
|
CI failures seem unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another hard-coded library moved to builtins for consistency and make it optional