Repository navigation
[tmva][sofie] Avoid undefined behavior in Clean_name - #23158
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 14h 52m 11s ⏱️ For more details on these failures, see this check. Results for commit 5d74917. |
guitargeek
approved these changes
Aug 28, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks. But again, please group multiple of these small fixes in one commit, for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cast the character passed to
std::isalnumtounsigned charinUTILITY::Clean_name.Passing a negative
chardirectly to the<cctype>classificationfunctions can result in undefined behavior.