Repository navigation
[RF] Deprecate RooTrace - #22999
Merged
Merged
[RF] Deprecate RooTrace#22999
Conversation
RooTrace's memory-tracing hooks (TRACE_CREATE/TRACE_DESTROY) are compiled out by default, and have been for years, so the class has been untested and effectively dead code. Remove all call sites across RooFit and mark the class itself as deprecated, to be removed in ROOT 6.44. General-purpose tools like AddressSanitizer or Valgrind are better suited for memory debugging today.
dpiparo
approved these changes
Aug 4, 2026
Test Results 23 files 23 suites 3d 15h 27m 2s ⏱️ For more details on these failures, see this check. Results for commit b6cd707. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RooTrace's memory-tracing hooks (TRACE_CREATE/TRACE_DESTROY) are compiled out by default, and have been for years, so the class has been untested and effectively dead code. Remove all call sites across RooFit and mark the class itself as deprecated, to be removed in ROOT 6.44. General-purpose tools like AddressSanitizer or Valgrind are better suited for memory debugging today.