Skip to content

Fix an auto-registration problem in the FitPanel unit test #22991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hageboeck merged 2 commits into from
Aug 4, 2026
Merged

Fix an auto-registration problem in the FitPanel unit test #22991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08abb7d
[gui] Make failures in fit panel unit tests easier to diagnose.
hageboeck Aug 3, 2026
ffc6f53
[tutorials] Add a TGraph to the objects displayed in a fit panel.
hageboeck Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions gui/fitpanel/test/UnitTesting.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "Math/PdfFuncMathCore.h"

#include <iostream>
#include <fstream>
#include <exception>
#include <stdexcept>
#include <cmath>
Expand Down Expand Up @@ -49,6 +50,10 @@ int equals(Double_t n1, Double_t n2, double ERRORLIMIT = 1.E-4)
int SelectEntry(TGComboBox* cb, const char* name)
{
TGTextLBEntry* findEntry = static_cast<TGTextLBEntry*>( cb->FindEntry(name) );
if (!findEntry) {
fprintf(stderr, "*****\nError: Did not find entry %s in combo box %s\n", name, cb->GetName());
throw std::runtime_error("Did not find the requested entry in a combo box.");
}
cb->Select(findEntry->EntryId());

return findEntry->EntryId();
Expand Down Expand Up @@ -450,13 +455,20 @@ class FitEditorUnitTesting
{
RedirectHandle_t gRH;

gSystem->RedirectOutput("outputUnitTesting.txt", first ? "w" : "a", &gRH);
constexpr auto logfile = "outputUnitTesting.txt";

fprintf(stdout, "\n***** %s *****\n", str);
gSystem->RedirectOutput(logfile, first ? "w" : "a", &gRH);

int status = (this->*func)();
fprintf(stdout, "\n***** %s *****\n", str);

gSystem->RedirectOutput(0, 0, &gRH);
int status = 1;
try {
status = (this->*func)();
gSystem->RedirectOutput(0, 0, &gRH);
} catch (std::exception &ex) {
gSystem->RedirectOutput(0, 0, &gRH);
fprintf(stderr, "Caught exception with message '%s'\n Check %s below.\n", ex.what(), logfile);
}

fprintf(stdout, "%s..........%s\n", str, status == 0 ? "OK" : "FAILED");

Expand Down Expand Up @@ -496,8 +508,16 @@ class FitEditorUnitTesting
// TODO: reenable once fit results are fixed
// result += MakeTest("TestTreeND.........", &FitEditorUnitTesting::TestTreeND);

fprintf(stdout, "\nRemember to also check outputUnitTesting.txt for "
"more detailed information\n\n");
if (result == 0) {
fprintf(stdout, "\nRemember to also check outputUnitTesting.txt for "
"more detailed information\n\n");
} else {
std::cout << "\n\nContents of outputUnitTesting.txt:\n\n";
std::ifstream file("outputUnitTesting.txt");
std::string line;
while (std::getline(file, line))
std::cout << "\t" << line << "\n";
}

return result;
}
Expand Down
1 change: 1 addition & 0 deletions tutorials/math/fit/ConfidenceIntervals.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ void ConfidenceIntervals()
double z, rnd, e=0.3;
TGraph2D *gr2 = new TGraph2D(ngr2);
gr2->SetName("Graph2DNoError");
gr2->SetDirectory(gDirectory); // Because it is never drawn, register the graph, so it shows up in the Fit Panel
TF2 *f2 = new TF2("f2",
"1000*(([0]*sin(x)/x)*([1]*sin(y)/y))+250",-6,6,-6,6);
f2->SetParameters(1,1);
Expand Down
Loading