Skip to content

[RF][HF] Guard testHistFactory XML round trip with HISTFACTORY_XML - #22974

Merged
guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:histfactory_xml
Jul 31, 2026
Merged

guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:histfactory_xml

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

This is already done for other parts of the test, and over time it was just forgotten to apply it consistently.

This is already done for other parts of the test, and over time it was
just forgotten to apply it consistently.
@guitargeek
guitargeek requested a review from bellenot July 31, 2026 11:33
@guitargeek guitargeek self-assigned this Jul 31, 2026
@guitargeek
guitargeek requested a review from hageboeck as a code owner July 31, 2026 11:33

@linev linev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this patch solves compilation problem on my Windows machine without libxml2

@bellenot bellenot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonas!

@guitargeek
guitargeek merged commit 0ee55a9 into root-project:master Jul 31, 2026
31 checks passed
@guitargeek
guitargeek deleted the histfactory_xml branch July 31, 2026 15:05
@guitargeek

Copy link
Copy Markdown
Contributor Author

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22974 to branch 6.40 requested by guitargeek

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants