Repository navigation
[df] Handle containers in RHist* filling - #22899
Conversation
Test Results 23 files 23 suites 3d 16h 13m 55s ⏱️ Results for commit cfe7102. ♻️ This comment has been updated with latest results. |
|
Hi! Thanks, this feature is what I was looking for when trying to switch my code from Histo to Hist. Giovanni |
|
Hi @gpetruc
Yes, the support should be a superset of what Histo can do, notably for nested collections. Weight columns will follow the same rules as value columns wrt broadcasting. |
613e0bd to
ecef742
Compare
hahnjo
changed the title
RHist fillingRHist* filling
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM. I think we should have added an include in the past, maybe that's a good opportunity to add it?
ecef742 to
31794b1
Compare
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you so much for this nice improvement!
It abstracts the loop when Exec'uting with data containers, in the following commit for RHist*FillHelper and in the future for the other FillHelpers.
As for the existing Histo actions, the sizes of all containers must match while scalars are broadcasted. As an extension, this works recursively, so nested vectors are handled one level at a time.
This reduces repeated arguments that must be consistent.
31794b1 to
cfe7102
Compare
4 participants
As for the existing Histo actions, the sizes of all containers must match while scalars are broadcasted. As an extension, this works recursively, so nested vectors are handled one level at a time.