Repository navigation
[test] Avoid using GetRootSys() in unit tests - #20807
Merged
Merged
Conversation
The input files for `testHistFactory` are always copied to the directory where the tests are run by CMake.
This is done in particular to avoid some usage of `GetRootSys()`.
It's not good to include the standard headers in a loop, and actually causes the test to fail in my environment by somehow causing symbol lookup failures. The errors are fixed by just not including `<vector>`, which is not necessary in Cling anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to rely less on environment variables like
ROOTSYS.See also the discussion in #20006 (comment)