Skip to content

[CMake] Avoid unneeded artifacts in the library installation directory #19044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitargeek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[CMake] Avoid unneeded artifacts in the library installation directory #19044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
143bae7
[CMake] Explicitly install byproducts of generating Core dictionaries
guitargeek Jun 14, 2025
b032e94
[CMake] Explicitly install the `modules.idx` file
guitargeek Jun 14, 2025
17436d9
[CMake] Explicitly install implicitly generated `pcm` files
guitargeek Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,23 +518,36 @@ else()
install(DIRECTORY ${CMAKE_BINARY_DIR}/etc/dictpch DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
endif()

# FIXME: move installation of PCMS in ROOT_GENERATE_DICTIONARY().
# We are excluding directories, which are accidentaly copied via unxpected behaviour of install(DIRECTORY ..)
install(
DIRECTORY ${CMAKE_BINARY_DIR}/lib/
DESTINATION ${CMAKE_INSTALL_LIBDIR}
FILES_MATCHING
PATTERN "*.pcm"
PATTERN "modules.idx"
PATTERN "JupyROOT" EXCLUDE
PATTERN "python*" EXCLUDE
PATTERN "cmake" EXCLUDE
PATTERN "pkgconfig" EXCLUDE
)

# modules.idx
if(runtime_cxxmodules)

ROOT_GET_LIBRARY_OUTPUT_DIR(library_output_dir)

# Explicitly install the modules that are built by Clang implicitly. See
# also the comment in rootcling_impl.cxx about the "horrible workaround" to
# fix the incremental builds. The list needs to be kept up to date manually,
# it is better than globbing for all pcm files from the library output
# directory. The platform-dependent system modules match the LoadModule()
# calls in TCling.cxx.
set(implicit_pcm_files
Cling_Runtime.pcm
Cling_Runtime_Extra.pcm
ROOT_Config.pcm
_Builtin_stddef.pcm
std.pcm
)
if(WIN32)
list(APPEND implicit_pcm_files vcruntime.pcm services.pcm)
elseif(APPLE)
list(APPEND implicit_pcm_files Darwin.pcm)
else()
list(APPEND implicit_pcm_files libc.pcm)
endif()
foreach(implicit_pcm_file ${implicit_pcm_files})
install(FILES ${library_output_dir}/${implicit_pcm_file} DESTINATION ${CMAKE_INSTALL_LIBDIR})
endforeach()
unset(implicit_pcm_files)

get_property(modules_idx_deps GLOBAL PROPERTY modules_idx_deps_property)
if(WIN32)
set(modules_idx_cmd COMMAND ${CMAKE_COMMAND} -E env PATH="${library_output_dir}\\\;%PATH%"
Expand All @@ -553,6 +566,8 @@ if(runtime_cxxmodules)
add_dependencies(modules_idx ${modules_idx_deps})
set_property(TARGET modules_idx PROPERTY modules_idx_file ${library_output_dir}/modules.idx)
set_directory_properties(PROPERTIES ADDITIONAL_CLEAN_FILES "${library_output_dir}/modules.timestamp")

install(FILES ${library_output_dir}/modules.idx DESTINATION ${CMAKE_INSTALL_LIBDIR})
endif()

ROOT_ADD_TEST_SUBDIRECTORY(tutorials)
Expand Down
12 changes: 8 additions & 4 deletions core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,14 @@ target_compile_definitions(Core PRIVATE
if (runtime_cxxmodules)
list(APPEND core_implicit_modules "-mSystemByproducts")
# Force generation of _Builtin_intrinsics from Core.
list(APPEND core_implicit_modules "-m" "_Builtin_intrinsics" "-mByproduct" "_Builtin_intrinsics")
list(APPEND core_implicit_modules "-mByproduct" "ROOT_Foundation_Stage1_NoRTTI")
list(APPEND core_implicit_modules "-mByproduct" "ROOT_Foundation_C")
list(APPEND core_implicit_modules "-mByproduct" "ROOT_Rtypes")
list(APPEND core_implicit_modules "-m" "_Builtin_intrinsics")

@pcanal pcanal Jul 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it would now be listed twice in core_implicit_modules, i.e. once more inside the new foreach loop.


set(byproducts _Builtin_intrinsics ROOT_Foundation_Stage1_NoRTTI ROOT_Foundation_C ROOT_Rtypes)
foreach(byproduct ${byproducts})
list(APPEND core_implicit_modules "-mByproduct" "${byproduct}")
install(FILES ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${byproduct}.pcm DESTINATION ${CMAKE_INSTALL_LIBDIR})
endforeach()
unset(byproducts)
endif(runtime_cxxmodules)

get_target_property(CORE_DICT_HEADERS Core DICT_HEADERS)
Expand Down
Loading