Skip to content

[cmake] Diagnose missing header (and include path) for externally built libraries. #9736

Closed

Description

@vgvassilev

ROOT has several externally built packages which end up in the dictionaries, such as Vc.

Currently, if the Vc is externally built, the MathCore dictionary needs to know its include location at rootcling-time but also when running ROOT (ROOT's runtime). If the person uses that approach does not pass this information, this leads to very subtle crash in modules and it takes time to setup a debug build and diagnose.

Instead, the dictionary which has an include to an externally built library (in ROOT_GENERATE_DICTIONARY) should be able to check if this include path is also passed in ROOT for its runtime. Otherwise, issue a diagnostic.

Activity

  1. changed the title [-][cmake] Diagnose missing header include paths for externally build libraries.[/-] [+][cmake] Diagnose missing header (and include path) for externally built libraries.[/+] on Jan 27, 2022
  2. ferdymercury commented on Jan 16, 2026

    @ferdymercury
    Collaborator

    tagging @guitargeek @hageboeck since they have been playing with runpaths and external libs.

    (Vc is deprecated so maybe no longer very important)

  3. added 2 commits that reference this issue on Jul 27, 2026
    909da55
    d4cee27
  4. guitargeek commented on Jul 27, 2026

    @guitargeek
    Contributor

    This issue still affects vdt, but I'm proposing to avoid including vdt in the modules to fix that:

  5. added a commit that references this issue on Jul 27, 2026
    3a9f593
  6. added a commit that references this issue on Aug 4, 2026
    ceb1ab7
  7. added 3 commits that reference this issue on Aug 4, 2026
    df4dc88
    6bb47b7
    a519dfb
  8. added a commit that references this issue on Aug 5, 2026
    e428dc5
  9. hageboeck commented on Aug 5, 2026

    @hageboeck
    Member

    With vc removed and xrootd and RVec being private dependencies (i.e. invisible in the headers), the proposed detection mechanism is hopefully not needed any more. We can reopen/rediscuss if other dependencies are found that would require this.

  10. self-assigned this
    on Aug 5, 2026
  11. github-actions commented on Aug 6, 2026

    @github-actions

    Hi @hageboeck, @bellenot,

    It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

    Sincerely,
    🤖

  12. github-actions commented on Aug 7, 2026

    @github-actions

    Hi @hageboeck, @bellenot,

    It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

    Sincerely,
    🤖

  13. added a commit that references this issue on Oct 16, 2026
    f6f7c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions