Fix Excel2003: set namespace if not exist - #56
Open
Mihoid wants to merge 1 commit into
Open
Conversation
Author
|
I will check what's wrong with |
Mihoid
force-pushed
the
fix/excel-2003-namespacing
branch
from
October 21, 2019 15:02
e1f509c to
847c071
Compare
Mihoid
force-pushed
the
fix/excel-2003-namespacing
branch
from
October 21, 2019 15:36
847c071 to
569ba70
Compare
Author
|
@chopraanmol1 Hi!🤝 Now PR looks good and test coverage fixed. 🙌🏼 |
Author
|
@amatsuda @Empact @scottwillson Hi! 🙌🏼 Could you check this PR, please. Thank you in advance! |
Contributor
|
Thanks for the fix - could you add a line to the test checking the namespace is as expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This PR will help to open/read hard readable files Excel2003 without namespaces in workbook.