Fix TypeScript errors in libs/utils (PR A) - #4
Closed
ronaldw07 wants to merge 3 commits into
Closed
Conversation
Updates TypeScript configuration to align with Total TypeScript recommendations for modern React/Next.js applications. Changes: - Update target from esnext to es2022 - Update module from esnext to preserve (for modern bundlers) - Update moduleResolution from node to bundler - Update lib to use es2022 instead of esnext - Add moduleDetection: force - Add verbatimModuleSyntax: true - Add noUncheckedIndexedAccess: true (prevents array/object access without checking if defined) - Add noImplicitOverride: true Fixes icssc#1379
- Update tsconfig.json files in packages and app to match Total TypeScript cheat sheet - Fix FuzzySearch.tsx lint errors (unused import, lexical declaration) - Add defensive checks in Schedules.ts, Map.tsx, scheduleHelpers.ts - Fix undefined access in download.ts and analytics.ts Fixes icssc#1379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes TypeScript errors introduced by stricter compiler settings by adding runtime guards and small type adjustments in libs and utility code.\n\nChanges:\n- Workspace TypeScript adjustments and path mappings\n- Safer access / null guards in apps/antalmanac/src/lib/* (download, termData, grades, websoc, tourExampleGeneration, locations)\n- Safer patterns in components under Calendar and RightPane\n- Test updates: apps/antalmanac/tests/termData.tsx\n\nRun locally: pnpm -w tsc --noEmit to verify error reduction before merging.