Skip to content

Treat blank environment variables as nil - #9

Open
yasseur1007 wants to merge 1 commit into
romul:masterfrom
yasseur1007:consider_blank_values_as_nil
Open

Treat blank environment variables as nil#9
yasseur1007 wants to merge 1 commit into
romul:masterfrom
yasseur1007:consider_blank_values_as_nil

Conversation

@yasseur1007

@yasseur1007 yasseur1007 commented Jun 23, 2017

Copy link
Copy Markdown

Consider blank variables as nil.

Useful when using "${ENV_VARIABLE}" way during the compile time, that is converted to "" when no env found at run time.

@romul

romul commented Jun 23, 2017

Copy link
Copy Markdown
Owner

Hello, @yasseur1007! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@romul

romul commented Jun 23, 2017

Copy link
Copy Markdown
Owner

Ebert has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/romul/newrelic.ex/pulls/9.

@yasseur1007

Copy link
Copy Markdown
Author

hi @romul can you have a look at this PR?
also i'm not sure the Ebert issue found is related to the changes i've made :)

@sb8244

sb8244 commented Aug 19, 2019

Copy link
Copy Markdown
Collaborator

Hi @yasseur1007. This is an old PR, but I'm wondering if you still need this functionality? If so, we can look at adding it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants