Skip to content

Implements direnv watch file functionality #224

Open
mawwwrk wants to merge 9 commits into
romkatv:v5from
mawwwrk:fix-direnv_watch
Open

Implements direnv watch file functionality #224
mawwwrk wants to merge 9 commits into
romkatv:v5from
mawwwrk:fix-direnv_watch

Conversation

@mawwwrk

@mawwwrk mawwwrk commented Jun 13, 2022

Copy link
Copy Markdown

fixes issue described in #202.

additional change: added additional folder in check for deps files, {,direnv/}, line 30.

@romkatv

romkatv commented Jun 13, 2022

Copy link
Copy Markdown
Owner

Thanks!

I merged it and made a few changes. I still need to incorporate json parsing (the one you have in the PR can fail produce incorrect results on well-formed json). My work-in-progress changes are here: https://github.com/romkatv/zsh4humans/tree/direnv. With luck I'll get back to it later this week.

@mawwwrk
mawwwrk force-pushed the fix-direnv_watch branch from 80f8233 to 64cf5bb Compare June 16, 2022 11:49
@tecosaur

Copy link
Copy Markdown

I'm curious, has this just been overlooked/forgotten about?

@romkatv

romkatv commented Jun 27, 2023

Copy link
Copy Markdown
Owner

Something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants