Handle all 2xx HTTP status codes as success - #2
Open
IFAKA wants to merge 1 commit into
Open
Conversation
Use response.ok instead of checking for status_code == 200 to properly handle 201, 202, 204, and other success codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The response handler only treats HTTP 200 as success:
This means valid success responses like 201 (Created), 202 (Accepted), or 204 (No Content) are incorrectly treated as errors and raise
APIError.Fix
Use
response.okwhich returnsTruefor any 2xx status code:Test