You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for opening this, @adity982! The feature is well-scoped and the implementation looks clean — good work on the case-insensitive filtering, the missing-arg validation, and the Windows USERPROFILE addition.
However, since you opened this PR, the Node.js API refactor (PR #159) was merged into main. This means:
Merge conflict — src/commands/list.js has been refactored: it now calls apiList() from src/api/list.js and only handles CLI output. Your filtering logic landed right where the business logic used to live, but in the new structure it belongs in the API layer.
What to do on rebase:
Rebase on latest main
Move the agent filter to src/api/list.js (the apiList function should accept options.agent and filter before returning)
In src/commands/list.js, just pass options.agent through to apiList
Update tests accordingly (they now test at the API level too)
Minor nit: When displaying Installed skills for cursor:, consider showing the original agent flag from the lockfile rather than the lowercased input — it makes the output more predictable.
Would you like any help with the rebase? Happy to review once it's updated.
Thanks for the clear rebase guidance. I will keep this draft until it is rebased on current main, the filter moves into src/api/list.js, the CLI passes options.agent through, and the updated API/CLI tests cover the behavior and display casing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds case-insensitive --agent/-a filtering to rolecraft list with focused CLI and command tests; closes #119.