Extensive rework: added a sidebar, bottom panel, options menu and more#48
Open
Eruyome wants to merge 81 commits into
Open
Extensive rework: added a sidebar, bottom panel, options menu and more#48Eruyome wants to merge 81 commits into
Eruyome wants to merge 81 commits into
Conversation
Sidebar shows enemy and ally pokemon cards, all at the same time. Sidebar can be toggled on/off in the settings menu. Sidebar can be positioned left or right off the the game app, can be set in the options menu. Showing/hiding enemy or ally party in theoptions menu also affects what's being displayed in the sidebar. While the sidebar is enabled/shown, the overlay enemy and ally pokemon cards are hidden via css classes.
… the sidebar. Quick and dirty implementation. But that information (x4 dmg, x0.25) was sorely missing.
…ar etc); fixed PokemonId conversion list. Passing the pokemon species id to the convertPokemonId() function works in some cases (getting the numeral id for the correct sprite), but doesn't work when you want to get the string pokemon name/identifier that pokeapi uses from the I2P map back. That name also wasn't returned in the proper format for variant pokemon.
Removed IV color coding for ally pokemon, made some small readability improvements. Added a trigger to change the sidebar pokemon card style for battles involving more than 8 pokemon (hide IVs and make things more compact), this should only affect trianer battles. Might need improvements for smaller screens.
…pokemon type fixes
Didn't work with something like `galar-mr-mime`.
…k, keyboard hotkey and gamepad buttons (simultaneously). Not fully tested. Doesn't seem to cause any issues simply by existing though.
No formatting changes, not all warnings resolved, just errors.
… compact. Old one can be switched to via css if needed.
…sues; refactored some functions
…ded bottom panel scaling; more refactoring
… show in the sidebar
…ng option; added different css classes for desktop/mobile (styling WIP)
…rds (desktop, kept it for mobile for now; fixed saving the wrong opacity values
…) using the wrong basePokemon (non-variant instead of variant)
…ids back to get the correct save data for their starters
…display fallbacks (no savedata found); small fixes
…mon (sidebar, WIP)
…mproved image drawing, fixed some caching issues
…nd include tags for ultra beasts and paradox pkemon
… effects to overlay cards; fixed some linting
… variant); fixed some region issue in the data set
…dded media queries for base font scaling
… anture tooltip to minified cards
… the statusbar position
…rage); added card repositioning if outside the window viewport.
… removed some debug logging
…d pokemon move and type weakness tooltips
Merge updates from Feature dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked extension from the ground up. It now has:
Project now uses lit-HTML for better UI updating.
All calls to pokeapi have been removed in favour of using static data files.
Project uses node to add linting, styling and other development features (including githooks). More details found in readme.
Continuation of #37