Update type icons to match Pokerogue sprites#22
Open
gsajith wants to merge 1 commit into
Open
Conversation
Owner
|
Can you keep the Chrome V3 PR and this one separate? I.e. this should work regardless of manifest upgrade, and viceversa. That way we can immediately merge this one while you complete the other PR |
gsajith
force-pushed
the
gauthams/update_type_sprites
branch
from
May 11, 2024 18:57
0e9c8cc to
db53cf0
Compare
Contributor
Author
|
Updated! |
Owner
|
I'm not totally sure about this change yet, I really do like the modern looking icons, although I can definitely see that using the same type icons that the game itself uses might be more user friendly. I'll let people debate about this |
Contributor
|
I think this should be a toggle rather than an overwrite And we should also probably ask PokeRogue themselves if we can use their sprites as a default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
I've copied the type icons from Pokerogue and added them as resources in the Chrome extension, and we're loading those instead of hitting the PokeAPI endpoint.
This depends on #21 being merged first.
How to test