Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SegmentedControl with auto/light/dark options, persisted via Mantine's built-in localStorage manager (mantine-color-scheme key). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Bank: replace hardcoded green.1/red.1/yellow.1 Mantine shades with light-dark() CSS classes for title and today-row backgrounds - DashboardDay: fix blue.2 today header → indigo light-dark(), reduce lecture heading dark overlay from 0.28 to 0.18 - Applications: redesign course section headers from heavy full-color banners to subtle light bg + 4px colored left border accent - Heading: increase bottom margin from md(16px) to lg(24px) - Diary: add marginTop to weekGrid for better header separation - Statistics: increase sectionTightTop from 0.2rem to 0.5rem - Card: lighten lectureFuture/Prepaid dark mode from yellow/green-9 to -8, reduce courseHeadingItem overlay from 0.2 to 0.15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Hlavní změny po komplexním review Mantine v9 migrace: **Design system / tokeny** - Aktivovat dosud nepoužívaný theme/tokens (rename z .css.ts na .ts kvůli ambient *.css declaration) - Rozšířit vars o radius, focusRing, text.heading, bg.muted, border.subtle/strong, borderShort - Codemod: nahradit ~60 duplicitních light-dark(#hex,…) literálů za vars tokeny napříč 18 *.css.ts soubory **A11y** - Login: name, autoComplete, aria-label na TextInputech (browser autocomplete + screen readers) - EditButton, Bank refresh: aria-label pro icon-only buttony (Tooltip ho nepřidává automaticky) - Loading: role=status, aria-live=polite, aria-busy - SubmitButton: nahradit FontAwesome spinner Mantine Button loading propem + aria-busy - nav: aria-label "Hlavní navigace" - Table.Th: scope=col jako theme default **Color scheme manager** - Explicitní localStorageColorSchemeManager s key "mantine-color-scheme" (Mantine v9 default je jiný klíč, takže persistence po reload nefungovala) **Inline styly (z 66 na 4 legitimní dynamic colors)** - Nový global/utility.css.ts s reusable utility classes (nowrap, bold, mb0, dimmedText, iconAfterText, …) - Refactor: Main, Login, Bank, DashboardDay, Heading, ClientAnalysis, Statistics, Diary, Card, Settings, Applications, Clients, Groups, ErrorBoundary, queryClient, GroupName, ClientPhone, ClientsList, AppDate, Notification, CourseCircle, SelectCourse, ColorPicker **Cleanup** - Smazat mantine-spotlight.css workaround (webpack sideEffects:true je přímý fix) - Odstranit Tooltip.postfix prop (8 callsites, propu komponenta ignorovala) - Odstranit nepoužívaný getDisplayName + zbytečný React import - CustomButton: vyhodit noop default (Mantine Button funguje s undefined onClick) - Stale komentář "Bootstrap" ve webpack.config.js - Opravit rozbité odsazení v package.json (řádky @FortAwesome a chroma-js) **ESLint** - Doplnit explicit project + node resolver pro import-resolver-typescript (webpack ESLint plugin context jinak neumí najít theme/tokens) Co je zbylé pro samostatný PR (vyšší riziko refactoru): - Vystěhovat globalStyle(".mantine-…") overrides v FormBase.css.ts a index.css.ts do theme.components.X.styles - Sjednotit 8 různých radius hodnot na var(--mantine-radius-{sm,md,lg}) Verifikováno: tsc, ESLint+Prettier, vitest 32/32, runtime na localhost:8000. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
===========================================
- Coverage 90.18% 78.05% -12.14%
===========================================
Files 17 18 +1
Lines 1161 1426 +265
===========================================
+ Hits 1047 1113 +66
- Misses 114 313 +199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.