Реализация приложения "Прогноз погоды" - #1
Open
rodionbgd wants to merge 39 commits into
Open
Conversation
Расширен функционал для мобильных устройств. Изменена структура приложения. Добавлены gh-actions для gh-pages.
vvscode
reviewed
Jan 29, 2022
vvscode
reviewed
Jan 29, 2022
vvscode
reviewed
Jan 29, 2022
vvscode
reviewed
Jan 29, 2022
vvscode
reviewed
Jan 29, 2022
| return; | ||
| } | ||
| removedCity.remove(); | ||
| localStorage.removeItem(removedIndex); |
There was a problem hiding this comment.
можно конечно и так, но если с редаксом работаешь - это лучше вынести в middleware
vvscode
reviewed
Jan 29, 2022
| import { menuCityList, store } from "./index"; | ||
| import { addCity, removeCity } from "./reducers/cities"; | ||
|
|
||
| export function addNewCity(city: City) { |
There was a problem hiding this comment.
и для этого прекрасно подходят redux-thunk, тогда не пришлось бы связывать эти фукнции с store
vvscode
reviewed
Jan 29, 2022
Comment on lines
+24
to
+25
| let c; | ||
| let lc; |
There was a problem hiding this comment.
это еще что ? не нужно так называть переменные, пожалуйста
vvscode
reviewed
Jan 29, 2022
vvscode
reviewed
Jan 29, 2022
Оптимизация функции определения местоположения
rodionbgd
force-pushed
the
weather_widget
branch
from
February 13, 2022 09:31
a1d7122 to
ad14f36
Compare
Максимальная частота обновления - 1 раз/мин.
rodionbgd
force-pushed
the
weather_widget
branch
from
February 13, 2022 09:32
ad14f36 to
a4a5670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.