Skip to content

RFC: Split stdlib Program into Init and deprecated - #19798

Closed
andres-erbsen wants to merge 2 commits into
rocq-prover:masterfrom
andres-erbsen:even-less-program
Closed

RFC: Split stdlib Program into Init and deprecated#19798
andres-erbsen wants to merge 2 commits into
rocq-prover:masterfrom
andres-erbsen:even-less-program

Conversation

@andres-erbsen

@andres-erbsen andres-erbsen commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

On top of #19797

  • Added changelog.
  • Added / updated documentation.
  • Opened overlay pull requests.
    • "Basics" module name collision
  • Replace remaining internal uses of newly deprecated tactics with existing tactics

- replace all uses of Program mode with refine; abstract
- Import as little of Program as possible
- prefer non-program tactics when straightforward
- keep Require statements for compat (for now)
@andres-erbsen andres-erbsen added kind: cleanup Code removal, deprecation, refactorings, etc. zARCHIVED: standard library Previously standard library (do not use anymore, now its own repo). part: program request: full CI Use this label when you want your next push to trigger a full CI. labels Oct 31, 2024
@andres-erbsen
andres-erbsen requested review from a team as code owners October 31, 2024 19:26
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 31, 2024
@andres-erbsen andres-erbsen added the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 31, 2024
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 31, 2024
@coqbot-app

coqbot-app Bot commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

🔴 CI failure at commit fd1459f without any failure in the test-suite

✔️ Corresponding job for the base commit 7e4ae8f succeeded

❔ Ask me to try to extract a minimal test case that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following target: ci-paramcoq
  • You can also pass me a specific list of targets to minimize as arguments.

@andres-erbsen

Copy link
Copy Markdown
Contributor Author
Definition fix_proto {A : Type} (a : A) := a.
Register fix_proto as program.tactic.fix_proto.

Is this required for Program to work well? Right now it's the only Register in a to-be-deprecated file.

@herbelin

herbelin commented Nov 4, 2024

Copy link
Copy Markdown
Member

Is this required for Program to work well?

It is used at elaboration time as a marker to control the Program obligation tactics, so it really goes together with the Program set of tactics. If not a problem, I would say that it is simpler for these tactics to work if it can be kept.

@proux01 proux01 added the needs: merge of dependency This PR depends on another PR being merged first. label Nov 7, 2024
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Dec 6, 2024
@coqbot-app

coqbot-app Bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

@coqbot-app coqbot-app Bot added the stale This PR will be closed unless it is rebased. label Jan 9, 2025
@proux01

proux01 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Stdlib is now in its own repo: https://github.com/coq/stdlib , if this PR is still current, please reopen it there.

@proux01 proux01 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc. needs: merge of dependency This PR depends on another PR being merged first. needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. part: program stale This PR will be closed unless it is rebased. zARCHIVED: standard library Previously standard library (do not use anymore, now its own repo).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants