Skip to content

feat: main page layout - #17

Merged
rockyroed merged 23 commits into
mainfrom
feat/layout
Oct 6, 2025
Merged

rockyroed merged 23 commits into
mainfrom
feat/layout

Conversation

@rockyroed

Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings October 6, 2025 11:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the main page layout structure with header functionality including branding, authentication, and theme switching capabilities.

  • Added header component with logo, dark/light mode toggle, and user authentication elements
  • Integrated Clerk authentication with theme support and conditional loading for testing
  • Set up testing infrastructure with Vitest configuration and necessary dependencies

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vitest.config.ts Configures Vitest testing environment with Nuxt and mock Clerk credentials
package.json Adds testing dependencies and moves @nuxt/test-utils to devDependencies
nuxt.config.ts Adds fonts module, conditionally loads Clerk, and sets dark background
app/layouts/default.vue Creates default layout with header component
app/components/Header/index.vue Implements header with logo, theme toggle, and authentication UI
app/assets/css/main.css Imports Nuxt UI styles and sets Poppins font globally
app/app.vue Replaces placeholder content with proper Nuxt layout structure
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread app/components/Header/index.vue Resolved
@rockyroed
rockyroed requested a review from pey2 October 6, 2025 11:56
@rockyroed
rockyroed marked this pull request as draft October 6, 2025 11:59
pey2
pey2 previously approved these changes Oct 6, 2025
@pey2
pey2 dismissed their stale review October 6, 2025 12:20

The merge-base changed after approval.

@rockyroed
rockyroed marked this pull request as ready for review October 6, 2025 14:31
@rockyroed
rockyroed requested review from Copilot and pey2 October 6, 2025 14:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

nuxt.config.ts:1

  • The '@clerk/nuxt' module was removed from the modules array but is still imported in the Header component. This will cause runtime errors when trying to use SignedIn, SignedOut, SignInButton, and UserButton components.
import tailwindcss from '@tailwindcss/vite';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

the logo conditional rendering cannot be server-side, because it's dependent on `colorMode.value1
Copilot AI review requested due to automatic review settings October 6, 2025 14:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

pey2
pey2 previously approved these changes Oct 6, 2025
@rockyroed
rockyroed dismissed pey2’s stale review October 6, 2025 14:39

The merge-base changed after approval.

@rockyroed
rockyroed requested a review from pey2 October 6, 2025 14:40
pey2
pey2 previously approved these changes Oct 6, 2025
@rockyroed
rockyroed dismissed pey2’s stale review October 6, 2025 14:44

The merge-base changed after approval.

@rockyroed
rockyroed merged commit eba8f9c into main Oct 6, 2025
3 checks passed
@rockyroed
rockyroed deleted the feat/layout branch October 8, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create main page layout Create avatar Create dark/light mode button Create header

3 participants