-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(ui): guard sessionStorage access against strict-privacy crash (#1453) #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meetp06
wants to merge
2
commits into
rocketride-org:develop
Choose a base branch
from
meetp06:fix/gh-1453-safe-sessionstorage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Aparavi Software AG | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| /** | ||
| * Safe `sessionStorage` accessors. | ||
| * | ||
| * Bare `sessionStorage` access throws a `SecurityError` in strict privacy | ||
| * modes (Safari Private Browsing, Chrome Incognito with third-party storage | ||
| * blocked, or when the UI is embedded in a sandboxed iframe). When that throw | ||
| * happens at module-eval time or during the initial React render, it aborts | ||
| * the whole render cycle and the user gets a blank white screen. | ||
| * | ||
| * These helpers swallow the exception and fall back to a harmless default so | ||
| * the app degrades to in-memory/limited functionality instead of crashing. | ||
| * | ||
| * NOTE: This helper is intentionally duplicated across the UI apps that do not | ||
| * share a common workspace package. Keep the copies in sync — apply any bug fix | ||
| * or new method (e.g. `clear`) to all three: | ||
| * - apps/chat-ui/src/utils/safeStorage.ts | ||
| * - apps/dropper-ui/src/utils/safeStorage.ts | ||
| * - apps/shell-ui/src/util/safeStorage.ts | ||
| */ | ||
| export const safeSessionStorage = { | ||
| /** | ||
| * Read a value from `sessionStorage`, returning `null` if storage is | ||
| * unavailable or the key is missing. | ||
| */ | ||
| getItem(key: string): string | null { | ||
| try { | ||
| return sessionStorage.getItem(key); | ||
| } catch { | ||
| return null; | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Write a value to `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| setItem(key: string, value: string): void { | ||
| try { | ||
| sessionStorage.setItem(key, value); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Remove a value from `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| removeItem(key: string): void { | ||
| try { | ||
| sessionStorage.removeItem(key); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Aparavi Software AG | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| /** | ||
| * Safe `sessionStorage` accessors. | ||
| * | ||
| * Bare `sessionStorage` access throws a `SecurityError` in strict privacy | ||
| * modes (Safari Private Browsing, Chrome Incognito with third-party storage | ||
| * blocked, or when the UI is embedded in a sandboxed iframe). When that throw | ||
| * happens at module-eval time or during the initial React render, it aborts | ||
| * the whole render cycle and the user gets a blank white screen. | ||
| * | ||
| * These helpers swallow the exception and fall back to a harmless default so | ||
| * the app degrades to in-memory/limited functionality instead of crashing. | ||
| * | ||
| * NOTE: This helper is intentionally duplicated across the UI apps that do not | ||
| * share a common workspace package. Keep the copies in sync — apply any bug fix | ||
| * or new method (e.g. `clear`) to all three: | ||
| * - apps/chat-ui/src/utils/safeStorage.ts | ||
| * - apps/dropper-ui/src/utils/safeStorage.ts | ||
| * - apps/shell-ui/src/util/safeStorage.ts | ||
| */ | ||
| export const safeSessionStorage = { | ||
| /** | ||
| * Read a value from `sessionStorage`, returning `null` if storage is | ||
| * unavailable or the key is missing. | ||
| */ | ||
| getItem(key: string): string | null { | ||
| try { | ||
| return sessionStorage.getItem(key); | ||
| } catch { | ||
| return null; | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Write a value to `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| setItem(key: string, value: string): void { | ||
| try { | ||
| sessionStorage.setItem(key, value); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Remove a value from `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| removeItem(key: string): void { | ||
| try { | ||
| sessionStorage.removeItem(key); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Aparavi Software AG | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| /** | ||
| * Safe `sessionStorage` accessors. | ||
| * | ||
| * Bare `sessionStorage` access throws a `SecurityError` in strict privacy | ||
| * modes (Safari Private Browsing, Chrome Incognito with third-party storage | ||
| * blocked, or when the UI is embedded in a sandboxed iframe). When that throw | ||
| * happens at module-eval time or during the initial React render, it aborts | ||
| * the whole render cycle and the user gets a blank white screen. | ||
| * | ||
| * These helpers swallow the exception and fall back to a harmless default so | ||
| * the app degrades to in-memory/limited functionality instead of crashing. | ||
| * | ||
| * NOTE: This helper is intentionally duplicated across the UI apps that do not | ||
| * share a common workspace package. Keep the copies in sync — apply any bug fix | ||
| * or new method (e.g. `clear`) to all three: | ||
| * - apps/chat-ui/src/utils/safeStorage.ts | ||
| * - apps/dropper-ui/src/utils/safeStorage.ts | ||
| * - apps/shell-ui/src/util/safeStorage.ts | ||
| */ | ||
| export const safeSessionStorage = { | ||
| /** | ||
| * Read a value from `sessionStorage`, returning `null` if storage is | ||
| * unavailable or the key is missing. | ||
| */ | ||
| getItem(key: string): string | null { | ||
| try { | ||
| return sessionStorage.getItem(key); | ||
| } catch { | ||
| return null; | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Write a value to `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| setItem(key: string, value: string): void { | ||
| try { | ||
| sessionStorage.setItem(key, value); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * Remove a value from `sessionStorage`. No-ops if storage is unavailable. | ||
| */ | ||
| removeItem(key: string): void { | ||
| try { | ||
| sessionStorage.removeItem(key); | ||
| } catch { | ||
| /* storage unavailable — degrade gracefully */ | ||
| } | ||
| }, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Three identical
safeStorage.tsfiles — consider extracting to a shared package.The same 71-line
safeSessionStoragewrapper is duplicated verbatim across three apps. If a bug is found or a method (e.g.,clear) needs to be added, all three copies must be updated in lockstep.apps/chat-ui/src/utils/safeStorage.ts#L37-L71: extract to a shared package or workspace utility.apps/dropper-ui/src/utils/safeStorage.ts#L37-L71: re-import from the shared location instead of maintaining a copy.apps/shell-ui/src/util/safeStorage.ts#L37-L71: re-import from the shared location instead of maintaining a copy.If a shared package isn't feasible in this monorepo right now, at minimum add a comment in each file pointing to the others so future changes stay synchronized.
📍 Affects 3 files
apps/chat-ui/src/utils/safeStorage.ts#L37-L71(this comment)apps/dropper-ui/src/utils/safeStorage.ts#L37-L71apps/shell-ui/src/util/safeStorage.ts#L37-L71🤖 Prompt for AI Agents