Repository navigation
feat(api-server): window/show and quit, and drop the tray for the GNOME mini player - #31
Merged
Merged
Conversation
…ME mini player The GNOME mini player is a panel icon of its own, so with the tray on the panel showed two identical icons. The tray icon now goes away once the mini player connects over the websocket. Electron on Linux can't make a tray icon again in the same process (its dbus objects stay exported), so it comes back after a restart rather than on disconnect. POST /window/show and POST /quit let the mini player offer the tray menu's Show and Quit. Refs #30
3 of 5 tasks
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the app side of #30 (part 2)
POST /api/v1/window/show(show + focus) andPOST /api/v1/quit, both 204, behind the same auth as the other control routesyourtune-gnome-miniplayeropens the websocket, the tray icon is destroyed. the client id is read from the token even with auth set to NONEone change from what i wrote in the issue: the tray doesn't come back on disconnect. electron on linux can't create a tray icon twice in one process, the second
new Traylogsorg.kde.StatusNotifierItem.Activate is already exportedand nothing shows up. so it stays gone until yourtune restartstested in the real app (xvfb + a private dbus session with a small StatusNotifierWatcher):
Status=Activewindow/show204,quit204 and the app exitstsc, oxlint, playwright 86/86