session: footer echo pump thread — echo-as-you-type during blocking inference - #368
Merged
Conversation
…rence (#367) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nce (#367) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jeqcho
marked this pull request as ready for review
August 11, 2026 03:34
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if self._pump_error is not None: | ||
| error = self._pump_error | ||
| self._pump_error = None | ||
| raise error |
…nterrupted join Fresh-eye review findings on #368: the teardown-ordering test only pinned join-by-return, and a KeyboardInterrupt inside the new join window skipped the terminal restore end_trial previously guaranteed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367.
With the footer active (cbreak, ECHO off) the only echo path is the poll pump, and the rollout loop blocks in
controller.next_actionfor a whole LLM inference, so operators type blind until the robot moves. This adds a session-owned echo pump thread, alive only inside the per-trial footer window, ticking onEvent.wait(ECHO_INTERVAL_S)and running the existing_pump_input()under a shared RLock. Completed lines still queue forpoll(); the console primitive stays threadless; pump-thread errors are re-raised from the nextpoll()to reuse rollout's degrade path. Amends plan 0042 (operator console) design decision 1; rationale and accepted costs inplans/0066-footer-echo-pump.md.Plan critique: 4 rounds (12, 9, 7, and 5 findings; rounds 1-3 each had one blocker: self-contradictory docs, wrong test-file name, fixed-signature
enable_footermonkeypatch in the enablement matrix). Round 4 clean of blockers; all findings applied. Locking, teardown ordering, degrade path, and coverage reachability independently re-verified each round.🤖 Generated with Claude Code