Accept comma-separated to_clusters destinations - #167
Draft
robjarawan wants to merge 2 commits into
Draft
Conversation
Test Results374 tests 373 ✅ 1m 41s ⏱️ Results for commit bd9da9d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53 and supersedes the closed fork PR #132.
ToClusters.after_accept()compares the wholeto_clustersvalue to the configured list. SoDDI.CMC,DDI.EDMdoes not matchmsgToClusters DDI.CMC; the callback moves the message torejectedeven though the local cluster is one of its destinations.So what I did was restore the original one-line fix on the current fork
developmentbase: split the message field on commas, trim each token, and keep the message when any token is configured locally. Single destinations and non-matches keep their existing behavior.Before:
After:
The original audit's exact single/multiple destination fixture also passes 2/2 after the fix.
Tests:
ToClustersregression: 2 passedThis branch also includes the local-fixture CI repair from #140 so the fork maintenance jobs do not depend on public dynamic flows.
Upstream issue MetPX#1752 remains open, while upstream PR MetPX#1740 was closed unmerged. Peter's comment on MetPX#1752 says this callback may be unused and removal may be the better long-term direction. That removal scope is still unresolved. This fork draft preserves the currently reachable callback's documented matching behavior without making the broader removal decision.