feat: skill for http clients - #19
Merged
Merged
Conversation
robhowley
commented
Mar 16, 2026
Owner
- External HTTP calls are infrastructure boundaries — isolate them behind a dedicated client module
- Use httpx.AsyncClient; never requests in async apps
- Reuse a single managed client instance; never instantiate per request or per call site
- Always configure explicit timeouts — connect, read, write, and pool
- Use tenacity for retries; never hand-roll retry loops
- Only retry transient failures on idempotent operations; don't retry 4xx
- Validate external payloads into typed schemas before they cross into the app
- Map upstream failures to domain-specific errors; don't leak HTTP concepts into business logic
- Centralize auth, base URL, headers, and credentials — never scatter or hardcode them
- Log and instrument at the boundary only; never log secrets
- Structure as a thin base client (transport/retry/logging) + thin vendor client (endpoints/validation/mapping)
- Make the integration layer trivially mockable in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.