Repository navigation
PenPressureTests reads pixels through CoreGraphics instead of NSBitmapImageRep - #333
Open
naco-siren wants to merge 1 commit into
Open
naco-siren wants to merge 1 commit into
naco-siren wants to merge 1 commit into
Conversation
The suite covers the shared brush engine, but it read the exported canvas through NSBitmapImageRep. It now reads raw bytes through BrushRaster.copy. The one test that needs AppKit, the Mac's canvas telling a tablet's events from a mouse's, moves to TabletEventPressureTests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PenPressureTests covers the shared brush engine, but it reads the exported canvas through NSBitmapImageRep, and one test builds an NSEvent. This makes the pixel reads go through CoreGraphics (BrushRaster.copy, then the bytes) and moves the NSEvent test, the Mac's canvas telling a tablet's events from a mouse's, to its own file, TabletEventPressureTests. The tests check the same things, pixel for pixel: the one that compared PNG encodings now compares the bytes.
No behavior change. 792 tests pass.
We run the shared test suites on the iPad fork too, and this was the one brush suite that couldn't; with it running there, an engine change that only shows on iOS gets caught before a merge rather than after.