Fix @HostRefParam with array/varargs parameters#176
Merged
Conversation
When JavaScript passes an array of HostRef pointers (e.g. [ptr1, ptr2]) to a Java @HostRefParam varargs parameter, Engine.invokeBuiltin() called ArrayNode.intValue() which silently returns 0, resolving the wrong object. - Engine: detect ArrayNode and resolve each element individually - BuiltinsProcessor: use TypeKind.ARRAY to detect array @HostRefParam and generate List-to-typed-array conversion in the lambda Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
andreaTP
force-pushed
the
fix/hostref-array-varargs
branch
from
3ef3ce9 to
d9603eb
Compare
Collaborator
Author
|
Found by @lbroudoux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JavaScript passes an array of HostRef pointers (e.g. [ptr1, ptr2]) to a Java @HostRefParam varargs parameter, Engine.invokeBuiltin() called ArrayNode.intValue() which silently returns 0, resolving the wrong object.