Skip to content

chore(tests): drive RPC over goridge net/rpc again - #7

Merged
rustatian merged 2 commits into
masterfrom
revert/connectrpc
Jul 15, 2026
Merged

chore(tests): drive RPC over goridge net/rpc again#7
rustatian merged 2 commits into
masterfrom
revert/connectrpc

Conversation

@rustatian

Copy link
Copy Markdown
Member

Part of the org-wide Connect-RPC revert: test helpers use the goridge net/rpc client with the current api-go jobs/v2 messages, deps bumped to the reverted releases. No changes outside tests/.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI review requested due to automatic review settings July 15, 2026 18:03
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rustatian, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b85070d2-444c-41f6-892f-bda64f5d473c

📥 Commits

Reviewing files that changed from the base of the PR and between ad40e84 and e6a2d6a.

⛔ Files ignored due to path filters (1)
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • tests/go.mod
  • tests/helpers/helpers.go
  • tests/jobs_nsq_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/connectrpc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the test RPC client plumbing from Connect-RPC back to a goridge net/rpc client for Jobs v2, aligning test helpers and dependencies with the org-wide Connect-RPC revert (tests-only scope).

Changes:

  • Replace Connect-RPC Jobs client usage with goridge net/rpc calls in test helpers and one NSQ test helper call site.
  • Remove Connect-RPC-related dependencies from tests/go.mod/tests/go.sum and bump RoadRunner-related deps to the intended reverted set.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/jobs_nsq_test.go Switch pipeline declare helper from Connect-RPC request to goridge net/rpc call.
tests/helpers/helpers.go Rework Jobs test client construction and helper RPC invocations to use goridge net/rpc.
tests/go.mod Drop Connect-RPC deps, add goridge dep, bump related RoadRunner/test deps.
tests/go.sum Remove Connect-RPC sums and update sums for bumped dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/helpers/helpers.go
Comment thread tests/helpers/helpers.go
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian
rustatian merged commit a61173e into master Jul 15, 2026
5 checks passed
@rustatian
rustatian deleted the revert/connectrpc branch July 15, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants