chore(tests): drive RPC over goridge net/rpc again - #7
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reverts the test RPC client plumbing from Connect-RPC back to a goridge net/rpc client for Jobs v2, aligning test helpers and dependencies with the org-wide Connect-RPC revert (tests-only scope).
Changes:
- Replace Connect-RPC Jobs client usage with goridge
net/rpccalls in test helpers and one NSQ test helper call site. - Remove Connect-RPC-related dependencies from
tests/go.mod/tests/go.sumand bump RoadRunner-related deps to the intended reverted set.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/jobs_nsq_test.go | Switch pipeline declare helper from Connect-RPC request to goridge net/rpc call. |
| tests/helpers/helpers.go | Rework Jobs test client construction and helper RPC invocations to use goridge net/rpc. |
| tests/go.mod | Drop Connect-RPC deps, add goridge dep, bump related RoadRunner/test deps. |
| tests/go.sum | Remove Connect-RPC sums and update sums for bumped dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Part of the org-wide Connect-RPC revert: test helpers use the goridge net/rpc client with the current api-go jobs/v2 messages, deps bumped to the reverted releases. No changes outside tests/.