docs: separate a missing Android build from a missing compiler - #379
Merged
Merged
Conversation
The guide covered only packages that need node-gyp, so a package whose installer picks a prebuilt binary by platform name had no entry: its message names a platform rather than a compiler, and no pure JS alternative is the answer. Names what still works, so the reader does not read it as every native package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide covered only packages that fail for want of a compiler. A package whose installer picks a prebuilt binary by platform name fails differently: it names a platform it does not recognise, and "use a pure JS alternative" is not the answer.
Reported in #375, where
npm installstopped atworkerd, whose installer carries a fixed list of platform keys with no Android entry. Cloudflare publishes no Android build, so nothing on the device changes it.Docs only. No code paths touched.