fix(gsheets-logger): clamp flush interval/batch size to safe positives (v0.2.2) - #2
Merged
Merged
Conversation
…s (v0.2.2) A non-numeric or zero/negative flushIntervalSec coerced to NaN, and setInterval(NaN) fires at ~1ms — a flush hot-loop that burns CPU and Sheets API quota. A NaN batch size silently disabled the size trigger. Both are now validated in parseConfig and fall back to the documented defaults (5s / 20 rows).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens gsheets-logger config parsing, released as v0.2.2.
flushIntervalSecandflushBatchSizewere passed straight throughNumber(...). A non-numeric value (e.g. a stray string) coerces toNaN:setInterval(fn, NaN * 1000)is treated assetInterval(fn, 0)→ the flush timer fires roughly every millisecond, a hot-loop that burns CPU and exhausts the Google Sheets API quota.NaNbatch size makesbuffer.length >= NaNalways false, silently disabling the size-based flush trigger.Both values are now validated in
parseConfig: non-finite or non-positive inputs fall back to the documented defaults (5s interval, 20-row batch). Valid values pass through unchanged.Tests
tsc --noEmitclean, bundle packages cleanly.