Skip to content

Fix Schema union memberships lookup #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ydah wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

Fix Schema union memberships lookup #5663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda4004
Fix Schema union memberships lookup
ydah Jul 9, 2026
41c390d
Test inherited Schema union memberships
ydah Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/graphql/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,8 @@ def union_memberships(type = nil)
inherited_um = find_inherited_value(:union_memberships, EMPTY_HASH).fetch(type.graphql_name, EMPTY_ARRAY)
own_um + inherited_um
else
joined_um = own_union_memberships.dup
find_inherited_value(:union_memberhips, EMPTY_HASH).each do |k, v|
joined_um = own_union_memberships.transform_values(&:dup)
find_inherited_value(:union_memberships, EMPTY_HASH).each do |k, v|
um = joined_um[k] ||= []
um.concat(v)
end
Expand Down
6 changes: 6 additions & 0 deletions spec/graphql/schema_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ class CustomSubscriptions < GraphQL::Subscriptions::ActionCableSubscriptions
assert_equal GraphQL::Query, schema.query_class
end

it "inherits union memberships when no type is given" do
schema = Class.new(Dummy::Schema)

assert_equal Dummy::Schema.union_memberships, schema.union_memberships
end

it "can override configuration from its superclass" do
custom_query_class = Class.new(GraphQL::Query)
extra_type_2 = Class.new(GraphQL::Schema::Enum)
Expand Down
Loading