Skip to content

Fix Dataloader Ruby version check#5662

Merged
rmosolgo merged 1 commit into
rmosolgo:masterfrom
ydah:fix-dataloader-ruby-version-check
Jul 10, 2026
Merged

Fix Dataloader Ruby version check#5662
rmosolgo merged 1 commit into
rmosolgo:masterfrom
ydah:fix-dataloader-ruby-version-check

Conversation

@ydah

@ydah ydah commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fix GraphQL::Dataloader#with to use RUBY_VERSION when selecting the legacy keyword argument implementation for CRuby before Ruby 3.

@ydah ydah force-pushed the fix-dataloader-ruby-version-check branch from 8997ca0 to 5470caf Compare July 9, 2026 14:36
@rmosolgo rmosolgo added this to the 2.6.6 milestone Jul 10, 2026
@rmosolgo

rmosolgo commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Oops ... how did this ever work? How did you run into this?

Thanks for fixing it!

@rmosolgo rmosolgo merged commit aa79336 into rmosolgo:master Jul 10, 2026
11 of 13 checks passed
@ydah ydah deleted the fix-dataloader-ruby-version-check branch July 10, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants