chore(miles): remove dead assert_partial_overlap_standalone_safe#23
Open
zhenyulincs wants to merge 1 commit into
Open
chore(miles): remove dead assert_partial_overlap_standalone_safe#23zhenyulincs wants to merge 1 commit into
zhenyulincs wants to merge 1 commit into
Conversation
The function was already a deprecated no-op (`del args; return None`) kept "for callsite stability" — but it has zero callsites anywhere in the repo (no imports, no dynamic getattr, no tests, no docs). Its own docstring explains why the guard was neutered: standalone create_placement_groups offsets the rollout pool, so zero-based `train ⊂ infer` is also true for valid disjoint standalone configs, making args-based intent detection unsafe; the RLIX_CONTROL_PLANE env-var is the only reliable signal, and RLix partial-overlap correctness is enforced by assert_rlix_topology (C1). Remove the dead function and its __all__ export entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dead function
assert_partial_overlap_standalone_safefrom miles/utils/rlix_validation.py and its__all__export entry.Why
It was already a deprecated no-op (
del args; return None), kept — per its own docstring — "for callsite stability." But there are no callsites: an exhaustive search (.py, tests,plans/, docs, dynamicgetattr) found the name only in its own definition and the__all__list.Its docstring also documents why the guard was neutered in the first place: the standalone
create_placement_groupspath offsets the rollout pool byactor_num_nodes * actor_num_gpus_per_node, so zero-basedtrain ⊂ inferis also true for valid disjoint standalone configs (e.g. 4 actor GPUs +--rollout-num-gpus 8). Auto-classifying intent from args is unsafe; theRLIX_CONTROL_PLANEenv-var is the only reliable standalone signal, and RLix partial-overlap correctness is enforced byassert_rlix_topology(C1). So the function had no remaining purpose.Safety
__all__entry are removed together, sofrom rlix_validation import *does not break with a dangling name.ast.parseclean; every remaining__all__entry resolves to a real definition.Test plan
ast.parseOK; all__all__names resolve