Skip to content

Replace m680x configure time check with version check - #6672

Open
historicattle wants to merge 1 commit into
rizinorg:devfrom
historicattle:meson
Open

Replace m680x configure time check with version check#6672
historicattle wants to merge 1 commit into
rizinorg:devfrom
historicattle:meson

Conversation

@historicattle

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description
Replace the meson m680x configure time check with capstone version checks (using CS_VERSION_PRE_RELEASE)

There are 2 more meson configure time checks, for m68k. Since they were added before alpha9, CS_VERSION_PRE_RELEASE is not available, so removing them this way is not possible

Test plan
none

Closing issues
none

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.17%. Comparing base (38c3bed) to head (8c8021b).

Additional details and impacted files
Files with missing lines Coverage Δ
librz/arch/p/analysis/analysis_m680x_cs.c 52.38% <ø> (ø)
librz/arch/p/arch_m680x_cs.c 21.42% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c3bed...8c8021b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@historicattle
historicattle marked this pull request as ready for review August 19, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant