Fix RABBIT_MALE reproduction bug + complete Dutch translation - #143
Open
Nozem1982 wants to merge 2 commits into
Open
Fix RABBIT_MALE reproduction bug + complete Dutch translation#143Nozem1982 wants to merge 2 commits into
Nozem1982 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, unrelated fixes bundled together:
1. Fix RABBIT_MALE reproduction not enabled
The HofBergmann bridge (v1.3 and v1.4) overrides RABBIT_MALE reproduction
age from 18 to 6 months, but never sets supported="true". Per the override
rules documented at the top of the file ("omitted = keep current value"),
the inherited supported="false" from the map stays in effect, so male
rabbits still can't reproduce despite the age fix. This adds the missing
supported="true" attribute in both bridge versions.
2. Complete Dutch (nl) translation
A large portion of translation_nl.xml (524 of 779 strings) contained the
English source text copied verbatim instead of a Dutch translation. This
fills in proper Dutch translations for all remaining strings, keeping
terminology consistent with the existing translated entries (e.g.
"veehoeder" for herdsman, "bedrijf" for husbandry). All %s/%d format
placeholders were preserved and verified against the original English
strings.